Run some mandatory tests in Travis#663
Merged
joelvai merged 7 commits intoCodaone:develfrom Sep 27, 2019
Merged
Conversation
If we're failing to connect to the local node, give up quickly to avoid build stuck.
This needed to run some tests from travis-ci.
joelvai
reviewed
Aug 21, 2019
.travis.yml
Outdated
| - pip install pyinstaller | ||
| - pip install --upgrade setuptools | ||
| - make install | ||
| - python3 -m pip install -r requirements-dev.txt |
Collaborator
There was a problem hiding this comment.
Skip this install for Mac since the test are only ran for Linux?
Also should the dev requirements be uninstalled afterwards?
Collaborator
Author
There was a problem hiding this comment.
Both true, thanks.
Escaping caused travis error
Merged
joelvai
approved these changes
Sep 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.