Refactor methods to get own orders#581
Merged
joelvai merged 3 commits intoCodaone:develfrom May 10, 2019
Merged
Conversation
Before this BitsharesOrderEngine class tried to use get_own_orders() which is nor defined neighter inherited.
This method is already defined inside StrategyBase class
* consistent property names: own_orders, all_own_orders * separate methods get_all_own_orders, get_own_orders: allows to use `refresh=True` as needed, also fixes ability to use `refresh` kwarg because it was unable to use on property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.