Add visionos as a new platform#11965
Conversation
|
Hi @dnkoutso, can you take a look at this PR? Am I missing something that needs to be addressed here? |
|
@gabrieldonadel can you |
Sure, I've just pushed a commit updating Gemfile.lock |
|
Seems that we'll need to update |
|
@gabrieldonadel from the cocoapods repo on your branch run Its a process but those integration specs catch some stuff... |
Should I run |
|
@gabrieldonadel might be List is with |
|
And yes inside CocoaPods/CocoaPods repo and be on your branch. |
|
Ohh I see @dnkoutso, this should be fixed now CocoaPods/cocoapods-integration-specs#343
|
|
I had one question in CocoaPods/cocoapods-integration-specs#343. |
|
@gabrieldonadel congratulations and thank you so much! |
|
Hi, How could use 1.13 to us visionOS platform? |
|
Was this tested before being released?
|
|
Do you have a |
|
Xcode 15 beta 8 on CircleCI has it installed, yes: https://discuss.circleci.com/t/xcode-15-rc-released-important-notice-for-visionos-sdk-users/49278#warning-for-visionos-sdk-users-warning-2 The problem is that it's expecting
But the |
|
Ah we might need to update https://github.com/CocoaPods/fourflusher/blob/master/lib/fourflusher/find.rb#L107-L126 different gem which we could update and cocoapods can start functioning |
|
Hmm maybe something is off between the two of them... |
yeah you are right @NachoSoto |
|
@dnkoutso any update on this? |
|
Experiencing the same problem with |
|
Would be great if |
|
FYI this is still broken on CocoaPods 1.15.0:
|
|
It's sad considering vision pro release in a couple of days |
|
I've looked through the code in CocoaPods/Core#745 and I don't fully understand why it doesn't work. The error comes from here: @platforms = platforms.map do |platform|
result = case platform.to_s.downcase
# Platform doesn't recognize 'macos' as being the same as 'osx' when initializing
when 'macos' then Platform.macos
else Platform.new(platform, nil)
end
unless valid_platform?(result)
raise Informative, "Unrecognized platform `#{platform}`. Valid platforms: #{VALID_PLATFORMS.join(', ')}"
end
result
endThis is how def valid_platform?(platform)
VALID_PLATFORMS.any? { |p| p.name == platform.name }
endWhich comes from def self.all
[ios, osx, watchos, visionos, tvos]
endI see there's logic there for lowercasing the name, but as far as I can tell it's correct. |
|
The lowercasing is only applied to the macos check. Looks like a simple fix - thanks for narrowing it down! |


This PR introduces
visionOSas a supported platform. This lays the groundwork for supporting visionOS as a new platform in CocoaPods.Closes #11961
Related to CocoaPods/Core#745 and CocoaPods/Xcodeproj#913