Make some logs less noisy#495
Merged
chrissie-c merged 2 commits intoClusterLabs:mainfrom Jan 31, 2024
Merged
Conversation
added 2 commits
January 24, 2024 10:24
... in handle_new_connection(). The caller has better context for whether a problem merits a warning or error, and the function's return code is sufficiently descriptive to do so. Some problems may be expected or able to be worked around. For example, Pacemaker's crm_mon attempts to contact pacemakerd IPC. On a Pacemaker Remote node, that IPC will be unavailable, and crm_mon can check the libqb return code to detect and handle that situation gracefully.
They're rather noisy, with every shm-based IPC connection generating multiple obscure messages like: debug: shm size:1048589; real_size:1052672; rb->word_size:263168 and every disconnect generating the rather unhelpful: debug: qb_ipcc_disconnect() along with multiple messages like: debug: Closing ringbuffer: /dev/shm/qb-10986-11014-34-26VRvs/qb-request-cmap-header All of these seem appropriate to trace level.
Author
|
@chrissie-c , this seems like a good idea to me :) but let me know if there's a reason not to |
Author
|
Also, I haven't gotten a chance to test this yet, but it's pretty straightforward |
chrissie-c
approved these changes
Jan 31, 2024
Contributor
chrissie-c
left a comment
There was a problem hiding this comment.
ACK, that seems sensible to me and tests OK.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to open an IPC connection, log at info level rather than warning or error, because the caller has better context to know whether it's a problem or not. Users get distracted by error logs that don't actually indicate a problem.
Also lower some spammy messages to trace level.