Add --disable-tests option#475
Conversation
Add --disable-tests to allow the user to disable tests. As a
side-effect, this will avoid the following build failure when check is
found:
libstat_wrapper.c:11:10: fatal error: gnu/lib-names.h: No such file or directory
11 | #include <gnu/lib-names.h>
| ^~~~~~~~~~~~~~~~~
This build failure is raised since version 2.0.5 and
78df90b
Fixes:
- http://autobuild.buildroot.org/results/450cfc36d4fd6dc71c138bec45f05b5a2d92a08d
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
Can one of the admins verify this patch? |
|
ok to test |
I have no objections to add --disable-tests, tho:
this part I don´t understand. We run CI on each build and we have never seen this problem before. What distribution / container / platform are you building on? Is the version of check too old? |
|
The build failure is raised by buildroot autobuilders. |
|
I think it would be better just to disable that test. It's a good thing to test libqb against other libcs where possible. |
|
Indeed, you could disable or remove this test however it still makes sense to disable all tests to save build time and disk space. |
Apologize for my complete ignorance, but what is buildroot.org? +1 on disabling the test when gnu/lib-names.h is not available. Regardless of the libc is in use, test suite should be built and executed. Build only doesn´t help much for the final results. Shaving 3/4 seconds to build is meaningless if the result doesn´t work on the libc in use. |
|
Why is gnu/lib-names.h even included? I don't see anything from this header file that gets used in libstat_wrapper.c. Removing the gnu/lib-names.h solves the build issue. |
|
I'll remove it. I suspect it was needed for some earlier OS version, but without that it's passed all the CI tests, so it's obviously fine without! |
Add
--disable-teststo allow the user to disable tests. As a side-effect, this will avoid the following build failure when check is found:This build failure is raised since version 2.0.5 and 78df90b
Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com