test: Clean /dev/shm a bit better#459
Merged
chrissie-c merged 3 commits intoClusterLabs:mainfrom Mar 18, 2022
Merged
Conversation
This isn't perfect, but it does tidy more of /dev/shm than previously. Because some of the tests leave empty directories we have no way of telling (in resources.test) whether they belong to this test run, another test run, or a running application.
kgaillot
reviewed
Feb 23, 2022
kgaillot
left a comment
There was a problem hiding this comment.
looks good to me, though I didn't test it
tests/resources.test
Outdated
| echo | ||
| echo "There were some empty leftovers (expected), removing them" | ||
| echo "${leftovers}" | tee /dev/stderr | xargs rm | ||
| echo "${leftovers}" | tee /dev/stderr |
There was a problem hiding this comment.
It seems odd to output just the names to both stdout and stderr, I would expect all the echos to go to one place. echo blah >&2 goes to just stderr
tests/resources.test
Outdated
| for dd in $leftovers; do | ||
| rm $dd | ||
| rmdir `dirname $dd` 2>/dev/null | ||
| done |
There was a problem hiding this comment.
could be worth functionizing since it's used twice
fabbione
approved these changes
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't perfect, but it does tidy more of /dev/shm than
previously. Because some of the tests leave empty directories
we have no way of telling (in resources.test) whether they
belong to this test run, another test run, or a running
application.