doxygen2man: Fix a couple of covscan-detected errors#425
Merged
chrissie-c merged 2 commits intoClusterLabs:masterfrom Oct 22, 2020
Merged
doxygen2man: Fix a couple of covscan-detected errors#425chrissie-c merged 2 commits intoClusterLabs:masterfrom
chrissie-c merged 2 commits intoClusterLabs:masterfrom
Conversation
kgaillot
reviewed
Oct 14, 2020
wferi
reviewed
Oct 19, 2020
Contributor
wferi
left a comment
There was a problem hiding this comment.
Wouldn't strnlen() be simpler? Or isn't it portable enough?
Contributor
Author
|
I have to admit, I'd not even heard of strnlen() thanks! |
a6623c9 to
ff98550
Compare
wferi
reviewed
Oct 19, 2020
| for (i=0; i< len; i++) { | ||
| buffer[i] = toupper(name[i]); | ||
| } | ||
| buffer[len] = '\0'; |
Contributor
There was a problem hiding this comment.
BTW you can also shave off the len declaration by using buffer[i] = 0 here (if this is your thing). :)
Contributor
Author
|
Fair point, but I think using len is clearer :) |
|
looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.