Skip to content

Some bugs spotted by coverity#399

Merged
chrissie-c merged 1 commit intoClusterLabs:masterfrom
chrissie-c:covscan-fixes-0520
May 28, 2020
Merged

Some bugs spotted by coverity#399
chrissie-c merged 1 commit intoClusterLabs:masterfrom
chrissie-c:covscan-fixes-0520

Conversation

@chrissie-c
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@kgaillot kgaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion

@chrissie-c
Copy link
Copy Markdown
Contributor Author

Looking closely into this, that NULL test is a complete red herring. Even covscan dpoesn't complain if I remove the existing one. The value of rb->shared_hdr has to be either valid or MAP_FAILED

@kgaillot
Copy link
Copy Markdown

Makes sense to me, looks good

@chrissie-c chrissie-c merged commit bdc7160 into ClusterLabs:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants