Some bugs spotted by coverity#399
Merged
chrissie-c merged 1 commit intoClusterLabs:masterfrom May 28, 2020
chrissie-c:covscan-fixes-0520
Merged
Some bugs spotted by coverity#399chrissie-c merged 1 commit intoClusterLabs:masterfrom chrissie-c:covscan-fixes-0520
chrissie-c merged 1 commit intoClusterLabs:masterfrom
chrissie-c:covscan-fixes-0520
Conversation
Contributor
Author
|
Looking closely into this, that NULL test is a complete red herring. Even covscan dpoesn't complain if I remove the existing one. The value of rb->shared_hdr has to be either valid or MAP_FAILED |
|
Makes sense to me, looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.