test: Add unit test for ipcs_connection_auth_set()#397
Merged
chrissie-c merged 1 commit intoClusterLabs:masterfrom Jun 3, 2020
chrissie-c:check_set_auth
Merged
test: Add unit test for ipcs_connection_auth_set()#397chrissie-c merged 1 commit intoClusterLabs:masterfrom chrissie-c:check_set_auth
chrissie-c merged 1 commit intoClusterLabs:masterfrom
chrissie-c:check_set_auth
Conversation
Contributor
Author
|
retest this please |
Contributor
Author
|
This is working on all platforms now. The coverity error is just covscan not understanding that fail_if() will abort the routine if the condition fails |
Only if we are root
jfriesse
approved these changes
Jun 1, 2020
Member
jfriesse
left a comment
There was a problem hiding this comment.
It's really neat idea to have this part of code tested so ACK.
Contributor
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only if we are root