trie: Don't assume that chars are unsigned < 126#386
Merged
chrissie-c merged 3 commits intoClusterLabs:masterfrom Mar 9, 2020
chrissie-c:unsigned-trie
Merged
trie: Don't assume that chars are unsigned < 126#386chrissie-c merged 3 commits intoClusterLabs:masterfrom chrissie-c:unsigned-trie
chrissie-c merged 3 commits intoClusterLabs:masterfrom
chrissie-c:unsigned-trie
Conversation
Trie fails on systems with unsigned chars when using characters over 126. This needs looking over and running through the CI systems
jfriesse
approved these changes
Mar 5, 2020
Member
jfriesse
left a comment
There was a problem hiding this comment.
Good catch, nice patch so ACK by me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trie fails on systems with unsigned chars when using characters over
126.
This needs looking over and running through the CI systems - hence the PR