Apply trailing slash sanitization to API_BASE_URL#5
Merged
Conversation
Co-authored-by: tayyebi <14053493+tayyebi@users.noreply.github.com>
Co-authored-by: tayyebi <14053493+tayyebi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Apply trailing slash sanitization to API_BASE_URL
Apply trailing slash sanitization to API_BASE_URL
Jan 7, 2026
- Updated the GitHub Actions release workflow to run tests before building release binaries. - Made the `sanitize_base_url` function public and added comprehensive tests for URL sanitization and API base URL retrieval. - Removed redundant test cases from various modules and organized tests into dedicated files for better maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API_BASE_URLlacks the trailing slash normalization applied toPUBLIC_BASE_URL, causing double slashes in constructed URLs when users provide trailing slashes.Changes
sanitize_base_url()toget_api_base_url()- single line change ensures consistent URL normalizationExample
Maintains backward compatibility - URLs without trailing slashes behave identically.
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.