chore: Let AWS Image Builder and ECR deal with deleting old images for us#476
Merged
mergify[bot] merged 5 commits intomainfrom Nov 30, 2023
Merged
chore: Let AWS Image Builder and ECR deal with deleting old images for us#476mergify[bot] merged 5 commits intomainfrom
mergify[bot] merged 5 commits intomainfrom
Conversation
Update snapshot. See details in [workflow run]. [Workflow Run]: https://github.com/CloudSnorkel/cdk-github-runners/actions/runs/6993027598 ------ *Automatically created by projen via the "upgrade-snapshot" workflow*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS Image Builder recently introduced lifecycle rules that can help us remove old images from EC2/ECR, and their descriptors on AWS Image Builder side.
CDK added automatic deletion of images in repositories so they can be deleted in CloudFormation easily. We had a custom resource to delete images, but now we can just use
autoDeleteImages.We still have to clean-up AWS Image Builder image descriptors and AMIs with a custom resource. We do this so removing our construct won't leave anything behind.
Resolves #471
BREAKING CHANGE: CDK 2.110.0 and above is required