keymaster: enable round-robin dialer by default.#91
Merged
rgooch merged 3 commits intoCloud-Foundations:masterfrom Jun 12, 2024
Merged
keymaster: enable round-robin dialer by default.#91rgooch merged 3 commits intoCloud-Foundations:masterfrom
rgooch merged 3 commits intoCloud-Foundations:masterfrom
Conversation
Member
Author
|
@cviecco: can we finally merge this? |
Contributor
|
Can you fix the conflicts? And ensure it works on MacOS and linux?. We can cross our fingers in windows for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 32.17% 32.39% +0.21%
==========================================
Files 75 75
Lines 9739 9739
==========================================
+ Hits 3134 3155 +21
+ Misses 5963 5942 -21
Partials 642 642 ☔ View full report in Codecov by Sentry. |
Member
Author
Conflicts fixed. Tested on Linux. Will test on MacOS when I get to the office. |
cviecco
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.