Role requesting certs#251
Merged
cviecco merged 16 commits intoCloud-Foundations:masterfrom Dec 9, 2024
Merged
Conversation
rgooch
requested changes
Dec 6, 2024
rgooch
approved these changes
Dec 8, 2024
Member
rgooch
left a comment
There was a problem hiding this comment.
Small nit. Can fix after landing if you want.
cmd/keymasterd/roleRequestingCert.go
Outdated
| // TODO: maybe add a check to ensure role certs cannot get role certs? | ||
| // | ||
| // TODO: maybe add a check to ensure no self-replication | ||
| // We dont anything to request a rolerequsting role for itself |
Member
There was a problem hiding this comment.
s/dont/don't want/
s/rolerequsting/rolerequesting/
rgooch
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.