Conversation
deshraj
requested changes
Jun 6, 2017
.gitignore
Outdated
| # Docs | ||
| _build | ||
| _static | ||
| _templates No newline at end of file |
Member
Author
There was a problem hiding this comment.
At the end of the file right?
docs/Makefile
Outdated
| # Catch-all target: route all unknown targets to Sphinx using the new | ||
| # "make mode" option. $(O) is meant as a shortcut for $(SPHINXOPTS). | ||
| %: Makefile | ||
| @$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) No newline at end of file |
Member
Author
There was a problem hiding this comment.
The make file is generated by sphinx-quickstart on its own. Should I still edit it?
Member
There was a problem hiding this comment.
Oh yeah, you are right. You can still edit it. it's good to have a newline at the end of the file.
Member
Author
There was a problem hiding this comment.
Yeah I've added a new line in my last commit
deshraj
requested changes
Jun 8, 2017
docs/Makefile
Outdated
| # Catch-all target: route all unknown targets to Sphinx using the new | ||
| # "make mode" option. $(O) is meant as a shortcut for $(SPHINXOPTS). | ||
| %: Makefile | ||
| @$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) No newline at end of file |
Member
There was a problem hiding this comment.
Oh yeah, you are right. You can still edit it. it's good to have a newline at the end of the file.
deshraj
reviewed
Jun 8, 2017
docs/Makefile
Outdated
| %: Makefile | ||
| @$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) No newline at end of file | ||
| @$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) | ||
|
No newline at end of file |
Member
There was a problem hiding this comment.
It seems like there is some indentation in the last line. Can you please remove it?
deshraj
approved these changes
Jun 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.