Fix BIO_set_indent() check

ndossche · t8m · commit 826374921a6b · 2023-02-08T17:03:52.000+01:00
This function returns an errorcode <= 0, but only < 0 is checked. Other callers that check the return value perform this check correctly. Fix it by changing the check to <= 0. CLA: trivial Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#20186)
diff --git a/crypto/asn1/asn1_parse.c b/crypto/asn1/asn1_parse.c
@@ -50,7 +50,7 @@ static int asn1_print_info(BIO *bp, long offset, int depth, int hl, long len,
             pop_f_prefix = 1;
         }
         saved_indent = BIO_get_indent(bp);
-        if (BIO_set_prefix(bp, str) <= 0 || BIO_set_indent(bp, indent) < 0)
+        if (BIO_set_prefix(bp, str) <= 0 || BIO_set_indent(bp, indent) <= 0)
             goto err;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ static int asn1_print_info(BIO *bp, long offset, int depth, int hl, long len,`
`50`	`50`	`pop_f_prefix = 1;`
`51`	`51`	`}`
`52`	`52`	`saved_indent = BIO_get_indent(bp);`
`53`		`- if (BIO_set_prefix(bp, str) <= 0 \|\| BIO_set_indent(bp, indent) < 0)`
	`53`	`+ if (BIO_set_prefix(bp, str) <= 0 \|\| BIO_set_indent(bp, indent) <= 0)`
`54`	`54`	`goto err;`
`55`	`55`	`}`
`56`	`56`