Apply random patches from some unknown source#9
Merged
rschu1ze merged 1 commit intoClickHouse/libssh-0.9.7from Feb 7, 2024
Merged
Apply random patches from some unknown source#9rschu1ze merged 1 commit intoClickHouse/libssh-0.9.7from
rschu1ze merged 1 commit intoClickHouse/libssh-0.9.7from
Conversation
This was referenced Feb 7, 2024
I don't see anything silently integrated into codebase. You can view commits being merged and if you need more clear reasons of patches you can always contact me as commits contain my contact information. I'm terribly sorry for all inconvenience caused. Please inquire me for any help |
Member
Author
|
@InfJoker Thanks and nevermind - shit happens :-) Let's continue discussion over at https://gitlab.com/libssh/libssh-mirror/-/issues/248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6
When https://github.com/ClickHouse/libssh was created (PR in ClickHouse repo), some patches were silently integrated into the libssh codebase, without documenting that these patches exist and where they come from. This happened probably in the aftermath of #1. Using plain upstream libssh breaks compilation ...
This PR splits these random patches at least into a separate PR. I still have no clue if this is a single patch or multiple, and where they come from
We should really really really stop practicing such terrible development practices, especially in security-relevant code.