Conversation
Bool is returned as a string by the ODBCDriver2 format, so the standard type parsers could not parse "true" and "false" into the expected integer. This fix resolves the issue by explicitly handling "true" and "false" values for Bool columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bool is returned as a string by the ODBCDriver2 format, so the standard type parsers could not parse
trueandfalseinto the expected integer. This fix resolves the issue by explicitly handlingtrueandfalsevalues for Bool columns.Fixes #486 Bool columns are represented as strings
Warning
This can be a breaking change for users of ODBC wrappers such as PyODBC. These wrappers extract type information automatically, and before this change the driver reported str as the expected type for inserting and reading data. With this change, it now expects bool, and attempting to insert or read a string will fail.
Similarly, from any ODBC client, attempting to read a Bool column as a string using
SQLGetData,SQLBindCol, etc. will return0and1instead oftrueandfalse, as it did before this change. This makes the driver more consistent with other drivers.