Skip to content

fix response close for getRowsUpdated(#1538)#1667

Merged
chernser merged 1 commit into
ClickHouse:mainfrom
wooEnrico:main
Jun 3, 2024
Merged

fix response close for getRowsUpdated(#1538)#1667
chernser merged 1 commit into
ClickHouse:mainfrom
wooEnrico:main

Conversation

@wooEnrico

@wooEnrico wooEnrico commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

The reason for the modification is com.clickhouse.r2dbc.ClickHouseResult Object Construction Parameters com.clickhouse.client.ClickHouseResponse did not call the close() method after use and did not release the database connection. Therefore, multiple calls can cause the database connection pool to have no available connections, resulting in timeout issues

Please refer to the problem description and code reproduction method for details #1538

@wooEnrico

Copy link
Copy Markdown
Contributor Author

The reason for the modification is com.clickhouse.r2dbc.ClickHouseResult Object Construction Parameters com.clickhouse.client.ClickHouseResponse did not call the close() method after use and did not release the database connection. Therefore, multiple calls can cause the database connection pool to have no available connections, resulting in timeout issues

Please refer to the problem description and code reproduction method for details #1538

@chernser chernser merged commit 5c7b40a into ClickHouse:main Jun 3, 2024
@chernser chernser linked an issue Jun 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clickhouse-r2dbc program is blocked by ClickHouseResponse

2 participants