added dummy data processor to access response input stream#1666
Merged
Conversation
mzitnik
approved these changes
Jun 2, 2024
This was
linked to
issues
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client wraps the response input stream with a data processor so the last one is only way to read data. Currently only few processors exist: RowBinary processors and TabSeparated for text formats. However other formats are expected to be read by 3rd party libraries and exposing input stream is fine in such cases.
The minimal approach here is to add
com.clickhouse.data.format.ClickHouseNativeProcessorthat will have minimal implementation and will let to access an input streamCloses:
- #1494
- #1567
- #1475
- #1376
Checklist
Delete items not relevant to your PR: