Fix flaky test 03562_parallel_replicas_remote_with_cluster#99658
Merged
alexey-milovidov merged 3 commits intomasterfrom Mar 19, 2026
Merged
Fix flaky test 03562_parallel_replicas_remote_with_cluster#99658alexey-milovidov merged 3 commits intomasterfrom
alexey-milovidov merged 3 commits intomasterfrom
Conversation
The test counted exact number of query_log entries with `ParallelReplicasQueryCount > 0`, but the number of entries varies depending on how the profile event gets attributed across the distributed coordinator and shard-level queries. Change to a boolean check (`> 0`) to verify that parallel replicas were used without relying on the exact count. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=95355&sha=1a2c01f3127165ddfe4f706a59a4e845674fff85&name_0=PR&name_1=Stateless%20tests%20%28arm_asan%2C%20azure%2C%20parallel%29 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [b8ad46b] Summary: ✅ AI ReviewSummaryThis PR fixes flakiness in ClickHouse Rules
Final Verdict
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89974
The test counted the exact number of
query_logentries withParallelReplicasQueryCount > 0, but this number varies depending on how the profile event gets attributed across the distributed coordinator and shard-level queries. For the one-shard case, the test expected1but sometimes gets2.Change to a boolean check (
countIf(...) > 0) to verify that parallel replicas were used without relying on the exact count.CI failure: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=95355&sha=1a2c01f3127165ddfe4f706a59a4e845674fff85&name_0=PR&name_1=Stateless%20tests%20%28arm_asan%2C%20azure%2C%20parallel%29
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes