Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a regression test for issue #81144, which caused a logical error ("Expected JOIN table expression to be table, table function, query or union node") when using parallel replicas with RIGHT JOIN chains. The issue was fixed in PR #97316.
Changes:
- Added test file
03977_pr_expected_join.sqlwith two test cases covering different RIGHT JOIN chain scenarios with parallel replicas - Added reference file
03977_pr_expected_join.referencewith expected output
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/queries/0_stateless/03977_pr_expected_join.sql | Regression test covering RIGHT JOIN chains with parallel replicas enabled, using both VIEW joins and remote() function joins |
| tests/queries/0_stateless/03977_pr_expected_join.reference | Expected output showing both queries return 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81144. Most probably was fixed by #97316
Changelog category (leave one):