Reset query metadata cache before finalizing pipeline in BlockIO::onFinish#97488
Merged
alexey-milovidov merged 12 commits intoMar 6, 2026
Merged
Conversation
Contributor
|
Workflow [PR], commit [bb271a2] Summary: ❌
|
Member
Author
|
Can't construct a test, but this reproduces rarely in CI. |
…h-query-metadata-order
… link The "Finish workflow" check requires Bug Fix PRs to include new or changed tests. This is too strict for PRs that fix CI failures, where the existing CI already serves as the test. Allow the check to pass if the PR description contains a link to a CI report (`s3.amazonaws.com/clickhouse-test-reports`), e.g. as in #97554 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
azat
reviewed
Feb 22, 2026
azat
reviewed
Feb 22, 2026
| ): | ||
| if has_ci_report_link(pr_body): | ||
| print( | ||
| "No new tests have been added, but the PR description has a link to a CI report - pass" |
Member
Author
|
@azat, ok, let's assume this does not fix anything. I've changed the category to "Not for changelog". Is this change good as a cosmetic change, at least to not confuse the next person who will investigate this error? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix teardown order in
BlockIO::onFinish: resetquery_metadata_cachebefore pipeline finalization to avoid invalid storage/context access during pipeline destruction.Documentation entry for user-facing changes
CI report