Skip to content

ci: run upgrade check only on release binary (fixes upgrade check)#95884

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:ci/upgrade-check-only-on-release
Feb 3, 2026
Merged

ci: run upgrade check only on release binary (fixes upgrade check)#95884
azat merged 1 commit intoClickHouse:masterfrom
azat:ci/upgrade-check-only-on-release

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Feb 3, 2026 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

It does not make a lot of sense to test binaries with sanitizers for upgrade check, since

  • there are tests with sanitizers in stress builds
  • previous release has regular build
  • it requires some hacks, since some builds does not support some features

Closes: #95652

@azat azat mentioned this pull request Feb 3, 2026
Closed
1 task
@azat azat requested a review from nikitamikhaylov February 3, 2026 12:23
@azat azat changed the title ci: run upgrade check only on release binary ci: run upgrade check only on release binary (fixes upgrade check) Feb 3, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 3, 2026 •
edited
Loading

Workflow [PR], commit [f3db4ca]

Summary: ✅

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 3, 2026
@nikitamikhaylov nikitamikhaylov self-assigned this Feb 3, 2026
@azat azat enabled auto-merge February 3, 2026 12:27
@fm4v
Copy link
Copy Markdown
Member

fm4v commented Feb 3, 2026

If you removing jobs run it for longer time because upgrade check doesn't run all tests

@azat azat added this pull request to the merge queue Feb 3, 2026
@azat azat removed this pull request from the merge queue due to a manual request Feb 3, 2026
@azat azat added this pull request to the merge queue Feb 3, 2026
@azat
Copy link
Copy Markdown
Member Author

azat commented Feb 3, 2026

What for?
This is the same job, just uses different binary

Merged via the queue into ClickHouse:master with commit dbb2a26 Feb 3, 2026
131 checks passed
@azat azat deleted the ci/upgrade-check-only-on-release branch February 3, 2026 13:49
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azat @fm4v @nikitamikhaylov @robot-clickhouse-ci-2