Do not hold a storage in storage snapshot#95396
Merged
Merged
Conversation
Contributor
|
Workflow [PR], commit [53a1f41] Summary: ❌
|
amosbird
approved these changes
Jan 28, 2026
This comment was marked as outdated.
This comment was marked as outdated.
579f8e5 to
ca449c0
Compare
Avogar
approved these changes
Jan 29, 2026
The storage should not outlive the execution after ClickHouse#92118, since it is hold in QueryPipeline.
ca449c0 to
53a1f41
Compare
Member
Author
|
Looks good, I hope I fixed all problems |
Merged
via the queue into
ClickHouse:master
with commit Jan 29, 2026
fff3e97
132 of 134 checks passed
Member
|
@azat, should we backport to 26.1? |
Member
Author
|
Let's not to, since it should not harm in general, plus maybe there are some places left that was relying on this (hope not) |
This was referenced Jan 30, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The storage should not outlive the execution after #92118, since it is hold in QueryPipeline.
Changelog category (leave one):