Skip to content

Fix stress tests always reporting success#95081

Merged
alexey-milovidov merged 1 commit intomasterfrom
fix-stress-test-always-success
Jan 25, 2026
Merged

Fix stress tests always reporting success#95081
alexey-milovidov merged 1 commit intomasterfrom
fix-stress-test-always-success

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jan 25, 2026

The variable test_results was being overwritten with an empty list before the loop that was supposed to iterate over it, causing the loop to never execute and all stress tests to always report success.

This bug was introduced in 97fe0b8 on December 16, 2025.

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

@alexey-milovidov @claude
Fix stress tests always reporting success
0780599 
The variable `test_results` was being overwritten with an empty list
before the loop that was supposed to iterate over it, causing the loop
to never execute and all stress tests to always report success.

This bug was introduced in 97fe0b8 on December 16, 2025.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@alexey-milovidov alexey-milovidov mentioned this pull request Jan 25, 2026
Merged
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 25, 2026 •
edited
Loading

Workflow [PR], commit [0780599]

Summary: ❌

job_name test_name status info comment
Stress test (amd_ubsan) failure
Logical error: Block structure mismatch in A stream: different number of columns: (STID: 0993-38e6) FAIL cidb, issue

@clickhouse-gh clickhouse-gh bot added the pr-ci label Jan 25, 2026
@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jan 25, 2026

Amazing! Now it runs.

@alexey-milovidov alexey-milovidov merged commit 3e8e6c0 into master Jan 25, 2026
132 of 134 checks passed
@alexey-milovidov alexey-milovidov deleted the fix-stress-test-always-success branch January 25, 2026 16:35
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 25, 2026
@alexey-milovidov alexey-milovidov self-assigned this Jan 26, 2026
@maxknv
Copy link
Copy Markdown
Member

maxknv commented Jan 26, 2026 •
edited
Loading

Thanks for the fix @alexey-milovidov!
This is a great showcase, see in the CI comment: CI detected an issue found and reported from another job (the AST fuzzer), recognized that it is the same issue in the Stress tests (using stack trace identifier), linked them together, and allowed the merge to proceed without blocking Mergeable Check as the only failure is already known and reported.

This was referenced Feb 6, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxknv maxknv Awaiting requested review from maxknv

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexey-milovidov @maxknv @robot-clickhouse-ci-1