Skip to content

tests: fix flaky 02350_views_max_insert_threads#95070

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
korowa:fix-flaky-mv-insert-threads
Jan 25, 2026
Merged

tests: fix flaky 02350_views_max_insert_threads#95070
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
korowa:fix-flaky-mv-insert-threads

Conversation

@korowa
Copy link
Copy Markdown
Contributor

@korowa korowa commented Jan 25, 2026

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Details

Closes #93249

According to the logs, stateless tests have concurrency control enabled (server logs from couple of failed jobs):

2026.01.16 11:09:29.655283 [ 1126 ] {} <Information> Application: ConcurrencyControl limit is set to 16 CPU slots with 'fair_round_robin' scheduler
...
2026.01.24 12:52:11.142069 [ 1147 ] {} <Information> Application: ConcurrencyControl limit is set to 16 CPU slots with 'fair_round_robin' scheduler
...
2026.01.23 23:12:22.797548 [ 1140 ] {} <Information> Application: ConcurrencyControl limit is set to 16 CPU slots with 'fair_round_robin' scheduler

and even --no-parallel tag not always helps to acquire 10 threads for the query execution

The fix is to disable concurrency control for the insert query, to allow always plan max_threads for it.

@korowa
tests: fix flaky 02350_views_max_insert_threads
c6876ae 
According to the logs, stateless tests have concurrency
control enabled, and even --no-parallel not always helps
to acquire 10 threads for the query execution.

The fix is to disable concurrency control for the insert
query, to allow always plan max_threads for it.
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Jan 25, 2026
@alexey-milovidov alexey-milovidov self-assigned this Jan 25, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 25, 2026 •
edited
Loading

Workflow [PR], commit [c6876ae]

Summary: ✅

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 25, 2026
@alexey-milovidov alexey-milovidov merged commit 7dadf66 into ClickHouse:master Jan 25, 2026
133 of 134 checks passed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: 02350_views_max_insert_threads

3 participants

@korowa @alexey-milovidov @robot-ch-test-poll3