Cherry pick #94617 to 25.10: Fix permission issues in BACKUP/RESTORE operations#94811
Merged
pamarcos merged 11 commits intobackport/25.10/94617from Jan 22, 2026
Merged
Cherry pick #94617 to 25.10: Fix permission issues in BACKUP/RESTORE operations#94811pamarcos merged 11 commits intobackport/25.10/94617from
pamarcos merged 11 commits intobackport/25.10/94617from
Conversation
1. Forbid RESTORE in readonly mode - RESTORE modifies data, so it should be blocked when `readonly` setting is enabled 2. Forbid `internal` setting for initial queries - this setting is only meant for ON CLUSTER secondary queries, not user-specified 3. Check BACKUP permissions before opening backup destination - prevents establishing S3/remote connections before access is verified
The previous check `if (readonly)` blocked RESTORE for both readonly=1 and readonly=2. However, readonly=2 is automatically set by the HTTP interface for non-POST requests to protect against accidental writes. This was causing legitimate RESTORE operations via HTTP sessions to fail. Now we only block readonly=1 (strict read-only mode explicitly set by the user) while allowing readonly=2 which is used by the HTTP interface for its automatic protection mechanism.
Fix permission issues in BACKUP/RESTORE operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #94617
Do not merge this PR manually
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Troubleshooting
If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the Original pull-request for
pr-backports-createdlabel, and delete if it's presented thereThe PR source
The PR is created in the CI job