Fix flaky test_restore_db_replica#94772

Merged

tuanpach merged 4 commits intoClickHouse:masterfrom

tuanpach:test-restore-db-replica

Feb 13, 2026

Member

tuanpach commented Jan 22, 2026

Changelog category (leave one):

CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

CIDB link

Wait for the database to be restored completely in test_restore_db_replica

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Contributor

clickhouse-gh bot commented Jan 22, 2026 •

edited

Loading

Workflow [PR], commit [c9e9b57]

Summary: ❌

job_name	test_name	status	info	comment
Upgrade check (amd_release)		failure
	Error message in clickhouse-server.log (see upgrade_error_messages.txt)	FAIL	cidb
Integration tests (amd_asan, targeted)		error

clickhouse-gh bot added the pr-ci label

bharatnc self-assigned this

tuanpach force-pushed the test-restore-db-replica branch 3 times, most recently from 570743c to 500702d Compare

February 3, 2026 01:54

Contributor

bharatnc commented Feb 7, 2026

Hi @tuanpach can you ping me once this PR is ready for review?

tuanpach added 2 commits

February 9, 2026 08:33


          - Split restore database replica into two parts: restore DB nodes and…

bb5a2d1

… restore DB replica node on Keeper

- Restore DB nodes on Keeper atomically.
- Fix waiting for the restore operation to complete in the test


          Fix test_replicated_database

f943bbb

tuanpach force-pushed the test-restore-db-replica branch from 500702d to f943bbb Compare

February 10, 2026 02:59

tuanpach requested a review from bharatnc

February 10, 2026 05:40

bharatnc reviewed

View reviewed changes

src/Databases/DatabaseReplicated.cpp Outdated Show resolved Hide resolved

bharatnc reviewed

View reviewed changes

src/Databases/DatabaseReplicated.cpp Show resolved Hide resolved

bharatnc reviewed

View reviewed changes

src/Databases/DatabaseReplicated.cpp Outdated Show resolved Hide resolved

bharatnc reviewed

View reviewed changes

src/Databases/DatabaseReplicated.cpp Outdated Show resolved Hide resolved

bharatnc reviewed

View reviewed changes

src/Databases/DatabaseReplicated.cpp Show resolved Hide resolved

tuanpach added 2 commits

February 11, 2026 01:09


          Address comments

a037d4e


          Compare czxid instead of ctime

c9e9b57

tuanpach requested a review from bharatnc

February 11, 2026 23:51

Contributor

bharatnc commented Feb 12, 2026

Is the upgrade check failure related?

bharatnc approved these changes

View reviewed changes

Member Author

tuanpach commented Feb 12, 2026

Is the upgrade check failure related?

I don't think it is related

https://pastila.clickhouse.com/?00236b72/cf7f96cfeb2b0a4cd23bbdde4eca5573#Jy+6Rh71nUkAQStyyGFYBA==GCM

tuanpach enabled auto-merge

February 12, 2026 08:00

tuanpach mentioned this pull request

Fix race condition in DatabaseReplicated::tryEnqueueReplicatedDDL #95865

Merged

tuanpach disabled auto-merge

February 12, 2026 08:17

tuanpach added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

tuanpach added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

tuanpach added this pull request to the merge queue

Merged via the queue into ClickHouse:master with commit ab34727

131 of 134 checks passed

tuanpach deleted the test-restore-db-replica branch

February 13, 2026 14:26

robot-ch-test-poll3 added the pr-synced-to-cloud label

Selfeer mentioned this pull request

Fix export task not being killed during s3 outage Altinity/ClickHouse#1564

Merged

27 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-ci pr-synced-to-cloud