Enhance estimation reliability for max_estimated_execution_time#94668
Merged
Enhance estimation reliability for max_estimated_execution_time#94668
max_estimated_execution_time#94668Conversation
Contributor
|
Workflow [PR], commit [b12b692] Summary: ❌
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the reliability of the max_estimated_execution_time setting by adding constraints to ensure estimation accuracy before throwing timeout errors. The change addresses an issue where queries could be incorrectly terminated too early due to unreliable estimates based on insufficient data.
Changes:
- Added a check requiring either 1% of rows to be read OR 1% of estimated time to elapse before enforcing
max_estimated_execution_time - Restructured the conditional logic to group timeout enforcement checks together
- Only applies the stricter estimation when
timeout_overflow_modeis set toTHROW
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pamarcos
approved these changes
Jan 20, 2026
Member
pamarcos
left a comment
There was a problem hiding this comment.
LGTM. I haven't been able to reproduce the flaky test even after thousands of runs.
Theoretically it failed ~0.07% of times, so it's quite unlikely to fail anyway.
Member
Author
|
Yes, but they are still failing pretty often |
…/ClickHouse into fix-01287_max_execution_speed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes #69624