Skip to content

S3Queue cleanup improvement#94412

Merged
kssenii merged 6 commits intomasterfrom
s3queue-account-failed-files
Jan 21, 2026
Merged

S3Queue cleanup improvement#94412
kssenii merged 6 commits intomasterfrom
s3queue-account-failed-files

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Jan 16, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

In S3(Azure)Queue Ordered mode clean up failed nodes by tracking limits (before that was done only in Unordered mode for both failed and processed, so now this will also be done for Ordered but only for failed nodes).

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 16, 2026 •
edited by kssenii
Loading

Workflow [PR], commit [bc41fe0]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_tsan, s3 storage, sequential, 2/2) failure
00993_system_parts_race_condition_drop_zookeeper FAIL cidb, issue ISSUE EXISTS
ThreadSanitizer: data race (STID: 1499-41d2) FAIL cidb IGNORED
Integration tests (amd_binary, 4/5) failure
test_peak_memory_usage/test.py::test_clickhouse_client_max_peak_memory_usage_distributed FAIL cidb, issue ISSUE EXISTS
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL issue ISSUE EXISTS
Performance Comparison (amd_release, master_head, 1/6) failure
Select historical data failure IGNORED
Performance Comparison (amd_release, master_head, 2/6) failure
Select historical data failure IGNORED
Performance Comparison (amd_release, master_head, 3/6) failure
Select historical data failure IGNORED
Performance Comparison (amd_release, master_head, 4/6) failure
Select historical data failure IGNORED
Performance Comparison (amd_release, master_head, 5/6) failure
Select historical data failure IGNORED
Performance Comparison (amd_release, master_head, 6/6) failure
Select historical data failure IGNORED
Integration tests (amd_asan, targeted) error IGNORED

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Jan 16, 2026
@antonio2368 antonio2368 self-assigned this Jan 19, 2026
@lesandie lesandie mentioned this pull request Jan 21, 2026
Closed
1 task
@kssenii kssenii added this pull request to the merge queue Jan 21, 2026
Merged via the queue into master with commit 31bde9e Jan 21, 2026
121 of 132 checks passed
@kssenii kssenii deleted the s3queue-account-failed-files branch January 21, 2026 16:16
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kssenii @antonio2368 @robot-ch-test-poll