Skip to content

Fix filter pushdown for SEMI JOIN#94340

Merged
novikd merged 1 commit intomasterfrom
fix-semi-join-filter-pushdown
Jan 16, 2026
Merged

Fix filter pushdown for SEMI JOIN#94340
novikd merged 1 commit intomasterfrom
fix-semi-join-filter-pushdown

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Jan 15, 2026

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix filter pushdown for SEMI JOIN using equivalence sets. Do not push the filter down if argument types have changed. Fixes #93264.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 15, 2026 •
edited by novikd
Loading

Workflow [PR], commit [03ca0d4]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_asan, db disk, old analyzer, 4/6) failure
test_max_temporary_data_size_on_disk/test.py::test FAIL cidb, issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Jan 15, 2026
@nickitat nickitat self-assigned this Jan 16, 2026
@novikd novikd added this pull request to the merge queue Jan 16, 2026
Merged via the queue into master with commit 81aa832 Jan 16, 2026
130 of 132 checks passed
@novikd novikd deleted the fix-semi-join-filter-pushdown branch January 16, 2026 16:26
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 16, 2026
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jan 16, 2026
This was referenced Jan 16, 2026
Closed
Closed
Closed
Closed
Closed
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickitat nickitat nickitat approved these changes

Assignees

@nickitat nickitat

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: Unexpected return type from A. Expected B. Got C. Action: (STID: 1611-3d1e)

4 participants

@novikd @nickitat @robot-ch-test-poll1 @robot-ch-test-poll2