Skip to content

Fix race in codec initialization of Base64#94209

Merged
rschu1ze merged 3 commits intomasterfrom
base64-race
Jan 14, 2026
Merged

Fix race in codec initialization of Base64#94209
rschu1ze merged 3 commits intomasterfrom
base64-race

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Jan 14, 2026

Resolves #94198

Also see aklomp/base64#65

The 1st commit in this PR removes the original base46 submodule. It referenced upstream but we need our own fork to make changes.

The actual fix is here and included in the 2nd commit in this PR.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze changed the title Base64 race Fix race in codec initialization of Base64 Jan 14, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 14, 2026

Workflow [PR], commit [02502ce]

Summary:

@clickhouse-gh clickhouse-gh bot added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jan 14, 2026
@alexey-milovidov
Copy link
Copy Markdown
Member

Please link from aklomp/base64#65

@rschu1ze rschu1ze added this pull request to the merge queue Jan 14, 2026
Merged via the queue into master with commit 4ad9c4f Jan 14, 2026
132 checks passed
@rschu1ze rschu1ze deleted the base64-race branch January 14, 2026 21:18
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ThreadSanitizer: data race (STID: 2705-5936)

4 participants