Skip to content

Revert Remove dangerous code#94108

Merged
rschu1ze merged 1 commit intomasterfrom
revert-93652
Jan 14, 2026
Merged

Revert Remove dangerous code#94108
rschu1ze merged 1 commit intomasterfrom
revert-93652

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Jan 13, 2026 •
edited
Loading

Reverts #93652

Fixes #93959

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze mentioned this pull request Jan 13, 2026
Closed
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 13, 2026 •
edited by rschu1ze
Loading

Workflow [PR], commit [3bf06f8]

Summary: ❌

job_name test_name status info comment
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL cidb, issue ISSUE EXISTS
BuzzHouse (amd_ubsan) failure
Logical error: 'assertHasValidVersionMetadata()' (STID: 2508-48ff) FAIL cidb IGNORED

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 13, 2026
@Algunenano Algunenano self-assigned this Jan 14, 2026
@rschu1ze rschu1ze enabled auto-merge January 14, 2026 09:56
@azat
Copy link
Copy Markdown
Member

azat commented Jan 14, 2026

The problem is leftovers from the 03632_temporary_table_not_allowed_columns test, we can fix it, but it is not OK to assume that the directory will be empty, i.e. in stress tests the server (or even regular) in case of abnormal server shutdown

@azat
Copy link
Copy Markdown
Member

azat commented Jan 14, 2026

#94174

@rschu1ze rschu1ze added this pull request to the merge queue Jan 14, 2026
Merged via the queue into master with commit c52a98c Jan 14, 2026
129 of 132 checks passed
@rschu1ze rschu1ze deleted the revert-93652 branch January 14, 2026 13:53
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat approved these changes

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Functional tests: "Scrapping system tables" failed

4 participants

@rschu1ze @azat @Algunenano @robot-ch-test-poll3