Revert "Remove bad test test_projection_rebuild_with_required_columns"#93971
Merged
alexey-milovidov merged 4 commits intomasterfrom Jan 19, 2026
Merged
Revert "Remove bad test test_projection_rebuild_with_required_columns"#93971alexey-milovidov merged 4 commits intomasterfrom
test_projection_rebuild_with_required_columns"#93971alexey-milovidov merged 4 commits intomasterfrom
Conversation
Contributor
|
Workflow [PR], commit [12f81b3] Summary: ❌
|
azat
reviewed
Jan 14, 2026
| from helpers.cluster import ClickHouseCluster | ||
|
|
||
| cluster = ClickHouseCluster(__file__) | ||
| node1 = cluster.add_instance("node1", user_configs=["configs/insert_limits.xml"]) |
Member
There was a problem hiding this comment.
Suggested change
| node1 = cluster.add_instance("node1", user_configs=["configs/insert_limits.xml"]) | |
| node1 = cluster.add_instance("node1", user_configs=["configs/insert_limits.xml"], randomize_settings=False) |
Likely this is the reason for flakiness
Member
There was a problem hiding this comment.
But this should not be needed anymore, since test uses explicit values
azat
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #93877
Fixes: #93365