Skip to content

Remove 'Bad Version' handling from S3Queue#93843

Merged
kssenii merged 1 commit intoClickHouse:masterfrom
ianton-ru:fix_s3_query_hive
Jan 12, 2026
Merged

Remove 'Bad Version' handling from S3Queue#93843
kssenii merged 1 commit intoClickHouse:masterfrom
ianton-ru:fix_s3_query_hive

Conversation

@ianton-ru
Copy link
Copy Markdown
Contributor

@ianton-ru ianton-ru commented Jan 9, 2026

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Remove 'Bad version' handling.

Documentation entry for user-facing changes

Fix for #81040. Remove 'Bad version' handling, this error must not happen in normal situation.
Happens in configuration with one bucket and one processing thread, but with several replicas. This configuration is invalid and in any way does not work properly.

  • Documentation is written (mandatory for new features)

@ianton-ru ianton-ru marked this pull request as ready for review January 9, 2026 17:24
@ianton-ru ianton-ru mentioned this pull request Jan 9, 2026
Merged
@kssenii kssenii added the can be tested Allows running workflows for external contributors label Jan 9, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 9, 2026 •
edited by kssenii
Loading

Workflow [PR], commit [9de944c]

Summary: ❌

job_name test_name status info comment
Bugfix validation (integration tests) failure
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[S3Queue-0-1-1] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[S3Queue-0-16-1] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[S3Queue-0-16-2] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[S3Queue-4-1-1] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[S3Queue-4-1-2] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[S3Queue-4-16-1] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[S3Queue-4-16-2] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[AzureQueue-0-1-1] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[AzureQueue-0-16-1] FAIL cidb IGNORED
test_storage_s3_queue/test_6.py::test_ordered_mode_with_hive[AzureQueue-0-16-2] FAIL cidb IGNORED
4 more test cases not shown
Integration tests (amd_tsan, 4/6) failure
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_same_node FAIL cidb, issue ISSUE EXISTS
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_different_nodes FAIL cidb, issue ISSUE CREATED
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_restores_on_same_node FAIL cidb IGNORED
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_restores_on_different_node FAIL cidb, issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jan 9, 2026
@ianton-ru ianton-ru mentioned this pull request Jan 9, 2026
Closed
1 task
@ianton-ru
Copy link
Copy Markdown
Contributor Author

ianton-ru commented Jan 12, 2026

Failed test test_backup_restore_on_cluster looks unrelated.
Fail of Bugfix validation is expected - test is failed randomly before, new test with binary version before PR.

@kssenii kssenii added this pull request to the merge queue Jan 12, 2026
Merged via the queue into ClickHouse:master with commit 480a892 Jan 12, 2026
129 of 132 checks passed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 12, 2026
@npakeer npakeer mentioned this pull request Jan 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ianton-ru @kssenii @robot-ch-test-poll3