Skip to content

Fix overflow in parsing/formatting debug check#93502

Merged
george-larionov merged 1 commit intomasterfrom
inconsistent_AST_formatting_caused_by_overflow
Jan 7, 2026
Merged

Fix overflow in parsing/formatting debug check#93502
george-larionov merged 1 commit intomasterfrom
inconsistent_AST_formatting_caused_by_overflow

Conversation

@george-larionov
Copy link
Copy Markdown
Member

Fixes #91974.
Caused by an overflow in max_query_size when it is adjusted during the debug check.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@george-larionov george-larionov changed the title fixing overflow in parsing/formatting debug check and adding test Fix overflow in parsing/formatting debug check Jan 6, 2026
@george-larionov george-larionov marked this pull request as ready for review January 6, 2026 17:10
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 6, 2026

Workflow [PR], commit [0363171]

Summary:

job_name test_name status info comment
Integration tests (amd_asan, db disk, old analyzer, 4/6) failure
test_dictionaries_update_and_reload/test.py::test_reload_while_loading FAIL cidb, issue ISSUE CREATED
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL cidb, issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 6, 2026
size_t size_t_max = -1;
size_t new_max_query_size = 0;
if (max_query_size == 0)
new_max_query_size = 0;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy may argue about a redundant store

@alexey-milovidov alexey-milovidov self-assigned this Jan 6, 2026
@george-larionov george-larionov added this pull request to the merge queue Jan 7, 2026
Merged via the queue into master with commit 37bf266 Jan 7, 2026
379 of 385 checks passed
@george-larionov george-larionov deleted the inconsistent_AST_formatting_caused_by_overflow branch January 7, 2026 16:44
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa)

3 participants