Skip to content

tests: optimize stateless tests to fit into 5G of memory#93362

Closed
azat wants to merge 17 commits intoClickHouse:masterfrom
azat:tests-fit-into-5G
Closed

tests: optimize stateless tests to fit into 5G of memory#93362
azat wants to merge 17 commits intoClickHouse:masterfrom
azat:tests-fit-into-5G

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jan 3, 2026

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

This is part of #82361, since it may requires changes to prakitka that may take sometime, while this contains enough changes on it's own

Changes:

  • some runs clickhouse-client in parallel - converted to use curl
  • some runs clickhouse-server - converted to integration tests

@azat azat changed the title tests: fit all stateless tests into 5G of memory tests: optimize stateless tests to fit into 5G of memory Jan 3, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 3, 2026

Workflow [PR], commit [175cec3]

Summary:

job_name test_name status info comment
Integration tests (arm_binary, distributed plan, 1/4) failure
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_same_node FAIL cidb
Integration tests (arm_binary, distributed plan, 2/4) failure
test_userspace_page_cache/test.py::test_size_adjustment FAIL cidb, issue
Integration tests (amd_tsan, 5/6) failure
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_same_node FAIL cidb, issue
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_different_nodes FAIL cidb
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_restores_on_same_node FAIL cidb
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_restores_on_different_node FAIL cidb, issue

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 3, 2026
@alexey-milovidov
Copy link
Copy Markdown
Member

Integration tests are way less approachable. For example, there was not a single case when integration tests ran successfully on my machine.

We need fewer integration tests, not more - e.g., all tests for Iceberg over S3 could be converted to functional.

@azat
Copy link
Copy Markdown
Member Author

azat commented Jan 4, 2026

Totally agree, I do not like to run the either (I think I was the first who introduced running separate clickhouse-server in stateless tests - 3afa946)

But those tests exceeds memory limits, and also the logic to start server in the stateless tests is complex.

I'm OK to mark them as no-parallel and increase memory limit instead, it will work for now, but not sure it is better.

Later, we can think about other options - provide some helpers to run server in stateless tests or make integration tests better, though there is a better way - just run pytest tests/integrations/... (but you need all dependencies installed, and not all tests will work, i.e. those who requires iptables)

@alexey-milovidov
Copy link
Copy Markdown
Member

Ok, actually the change is acceptable, let's proceed...

@azat
Copy link
Copy Markdown
Member Author

azat commented Jan 5, 2026

OK, let me merge this and rebase #82361 on top

@azat azat enabled auto-merge January 5, 2026 08:38
@azat azat added this pull request to the merge queue Jan 5, 2026
@azat azat removed this pull request from the merge queue due to a manual request Jan 5, 2026
@antaljanosbenjamin antaljanosbenjamin self-assigned this Jan 5, 2026
@azat
Copy link
Copy Markdown
Member Author

azat commented Jan 7, 2026

@antaljanosbenjamin likely it will be merged as #82361

@azat azat closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants