Conversation
Contributor
azat
reviewed
Jan 3, 2026
|
|
||
| _, took = elapsed(node.query, f"select * from data") | ||
| assert took < 1 | ||
| assert took < 3 |
Member
There was a problem hiding this comment.
Looks OK, though I think we can do better, we need to measure the query_duration_ms from system.query_log, since for sanitizers even starting the client binary can take sometime
It reports 1.0x seconds, but I don't see it on the server side - https://pastila.nl/?00328ceb/1edad0ab0cccc0bb0facfe662450c4ce#i+/GGP//s0aRB9BPHMdxrQ==GCM
And the slowest part is MinIO
2026.01.03 17:45:15.763555 [ 15150 ] {2b7d44eb-96d7-493c-b7b7-ecf1a314f14d} <Test> AWSClient: Make S3 request to: https://minio1:9001/root/data/qyu/rnkvbdzoeehuysdsjvzgykfswmooe, aws sdk attempt: 1, clickhouse attempt: 1, kind: Write
2026.01.03 17:45:16.285502 [ 15150 ] {2b7d44eb-96d7-493c-b7b7-ecf1a314f14d} <Trace> WriteBufferFromS3: Single part upload has completed. Details: bucket root, key data/qyu/rnkvbdzoeehuysdsjvzgykfswmooe, size 8003050
I tried to hack MinIO to forbid fsync, but it did not work - #92645
Member
There was a problem hiding this comment.
But let's merge as-is to make CI feel better
azat
approved these changes
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes rare flakiness of tests that check config changes on the fly w/o a server restart. Unfortunately, there is no reliable way to check for an unlimited case, so we only increase the arbitrary check from "<1" to "<3". This is because in the limited case, it should be ">3", and we need to distinguish between these cases.
Fixes: #93251
Fixes: #86098
Fixes: #86963
Fixes: #85563