Revert #62987 - Fix possible CHECKSUM_DOESNT_MATCH (and others) during replicated fetches#92730
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Dec 20, 2025
Conversation
…ers) during replicated fetches It is not possible to fix it reliably after server started to write exceptions in the response body in case of errors, so let's just revert all of this. The DataPartsExchange is safe anyway, since it has proper checksums.
Contributor
|
Workflow [PR], commit [ac17210] Summary: ❌
|
alexey-milovidov
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
It is not possible to fix it reliably after server started to write exceptions in the response body in case of errors, so let's just revert all of this.
The DataPartsExchange is safe anyway, since it has proper checksums.
Reverts: #62987
Fixes: #83373