Skip to content

Fixes for temporary files settings and metrics#92388

Merged
vdimir merged 8 commits intomasterfrom
vdimir/test_03514_grace_hash_join_logical_error
Jan 2, 2026
Merged

Fixes for temporary files settings and metrics#92388
vdimir merged 8 commits intomasterfrom
vdimir/test_03514_grace_hash_join_logical_error

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Dec 17, 2025 •
edited by fm4v
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

External aggregation/sorting/join now respect query setting temporary_files_codec in all contexts. Fixed missing profile events for grace hash join

Close #90174 (no issue there, we just cannot randomize temporary_files_buffer_size a lot, since in test run with s3 setup we have only 1G tmp storage and with small buffer size we flush a lot)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 17, 2025 •
edited by vdimir
Loading

Workflow [PR], commit [bd14b47]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_asan, distributed plan, parallel, 2/2) failure
02346_text_index_parallel_replicas FAIL cidb, issue ISSUE EXISTS
Integration tests (amd_tsan, 2/6) failure
test_storage_s3_queue/test_5.py::test_shutdown_order FAIL cidb, issue ISSUE EXISTS
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting in Function_or: the query: (STID: 1941-1bfa) FAIL cidb, issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 17, 2025
@vdimir vdimir force-pushed the vdimir/test_03514_grace_hash_join_logical_error branch from 8d27c36 to a7f4e08 Compare December 22, 2025 15:32
@vdimir vdimir changed the title investigating 03514_grace_hash_join_logical_error Fixes for temporary files settings and metrics Dec 22, 2025
@vdimir vdimir added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Dec 23, 2025
@vdimir vdimir force-pushed the vdimir/test_03514_grace_hash_join_logical_error branch from 3d6e093 to 79071e3 Compare December 23, 2025 14:51
vdimir
vdimir commented Dec 24, 2025
View reviewed changes
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Dec 24, 2025

Integration tests (amd_binary, 4/5) failure
test_merge_tree_s3/test.py::test_merge_canceled_by_s3_errors[node-broken_s3] FAIL IGNORED

#87560

@kssenii kssenii self-assigned this Dec 29, 2025
kssenii
kssenii reviewed Dec 29, 2025
View reviewed changes
@vdimir @kssenii
update temporary_files_buffer_size randomization
bd14b47 
Co-authored-by: Kseniia Sumarokova <kssenii@clickhouse.com>
@vdimir vdimir added this pull request to the merge queue Jan 2, 2026
Merged via the queue into master with commit 01b6412 Jan 2, 2026
127 of 131 checks passed
@vdimir vdimir deleted the vdimir/test_03514_grace_hash_join_logical_error branch January 2, 2026 11:55
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky 03514_grace_hash_join_logical_error (Failed to reserve ... bytes for temporary file)

3 participants

@vdimir @kssenii @robot-ch-test-poll1