Skip to content

Fix inconsistent AST formatting of arrayElement with negate literal#92293

Merged
Avogar merged 6 commits intoClickHouse:masterfrom
Avogar:fix-ast-formatting
Dec 18, 2025
Merged

Fix inconsistent AST formatting of arrayElement with negate literal#92293
Avogar merged 6 commits intoClickHouse:masterfrom
Avogar:fix-ast-formatting

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Dec 16, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix inconsistent AST formatting of arrayElement with negate literal.
Closes #92288
Closes #92212
Closes #91832
Closes #91789
Closes #91735
Closes #88495
Closes #92386

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@Avogar Avogar changed the title Fix inconsistent AST formatting of arrayElement with negate literal Attempt to fix inconsistent AST formatting of arrayElement with negate literal Dec 16, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 16, 2025 •
edited by Avogar
Loading

Workflow [PR], commit [6e19a51]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_tsan, 4/6) failure
test_restore_db_replica/test.py::test_query_after_restore_db_replica[rename table-with exists table-no restart] FAIL cidb, issue ISSUE EXISTS
AST fuzzer (amd_ubsan) failure
Logical error: Block structure mismatch in A stream: different number of columns: (STID: 0993-21b2) FAIL cidb, issue ISSUE CREATED
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL cidb, issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Dec 16, 2025
@Avogar Avogar mentioned this pull request Dec 16, 2025
Closed
1 task
@azat azat self-assigned this Dec 17, 2025
azat
azat reviewed Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments before I found yet another fix of this problem - #92340

@Avogar Avogar marked this pull request as ready for review December 17, 2025 12:38
@azat
Copy link
Copy Markdown
Member

azat commented Dec 17, 2025

Now we need to decide this one or #92340 (cc @alexey-milovidov), though there are lots of tests failed, and I think we can merge this as a first step (it should not break any new formatting, so this should be safe)

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Dec 17, 2025

think we can merge this as a first step (it should not break any new formatting, so this should be safe)

Agree. It should fix lots of Inconsistent AST formatting failures in CI and make CI better. #92340 will take some time to merge and we can spend more time on it with no rush if needed

@Avogar Avogar added this pull request to the merge queue Dec 18, 2025
@Avogar Avogar changed the title Attempt to fix inconsistent AST formatting of arrayElement with negate literal Fix inconsistent AST formatting of arrayElement with negate literal Dec 18, 2025
Merged via the queue into ClickHouse:master with commit b8465c3 Dec 18, 2025
127 of 131 checks passed
@Avogar Avogar deleted the fix-ast-formatting branch December 18, 2025 14:45
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 18, 2025
@GrigoryPervakov GrigoryPervakov mentioned this pull request Dec 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment