Skip to content

Fix logical error with join_use_nulls and cross join#91853

Merged
vdimir merged 1 commit intomasterfrom
vdimir/issue_87016_unexpected_return_type
Dec 15, 2025
Merged

Fix logical error with join_use_nulls and cross join#91853
vdimir merged 1 commit intomasterfrom
vdimir/issue_87016_unexpected_return_type

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Dec 10, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

  • Fix logical error with join_use_nulls and multiple joins along with cross join.

Close #87016

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 10, 2025 •
edited
Loading

Workflow [PR], commit [5821b99]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_binary, 1/5) failure
test_async_insert_adaptive_busy_timeout/test.py::test_with_replicated_merge_tree_multithread FAIL cidb, issue
Integration tests (amd_tsan, 3/6) failure
test_restore_db_replica/test.py::test_query_after_restore_db_replica[rename table-with exists table-no restart] FAIL cidb, issue
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb, issue
BuzzHouse (amd_tsan) failure
Logical error: Function writeSlice expects same column types for GenericArraySlice and GenericArraySink. FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Dec 10, 2025
@serxa serxa self-assigned this Dec 10, 2025
@vdimir vdimir force-pushed the vdimir/issue_87016_unexpected_return_type branch from d186466 to ed33593 Compare December 12, 2025 11:01
@vdimir vdimir force-pushed the vdimir/issue_87016_unexpected_return_type branch from ed33593 to 5821b99 Compare December 12, 2025 15:23
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Dec 12, 2025 •
edited
Loading

Integration tests (amd_asan, db disk, old analyzer, 5/6) failure
test_cluster_discovery/test.py::test_cluster_discovery_startup_and_stop FAIL cidb
test_cluster_discovery/test.py::test_cluster_discovery_macros

From the first glance looks like sporadic failure due to many failpoints triggered or slow run, created issue #92062

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Dec 15, 2025

BuzzHouse (amd_tsan) failure
Logical error: Function writeSlice expects same column types for GenericArraySlice and GenericArraySink.

#57243

@vdimir vdimir added this pull request to the merge queue Dec 15, 2025
Merged via the queue into master with commit cc489dc Dec 15, 2025
246 of 256 checks passed
@vdimir vdimir deleted the vdimir/issue_87016_unexpected_return_type branch December 15, 2025 14:25
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 15, 2025
@alexey-milovidov alexey-milovidov mentioned this pull request Feb 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serxa serxa serxa approved these changes

Assignees

@serxa serxa

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected return type from concat. Expected String. Got Nullable(String)

3 participants

@vdimir @serxa @robot-ch-test-poll4