Skip to content

Do not prune images from integration tests#91843

Merged
Felixoid merged 1 commit intomasterfrom
dont-prune-images
Dec 11, 2025
Merged

Do not prune images from integration tests#91843
Felixoid merged 1 commit intomasterfrom
dont-prune-images

Conversation

@Felixoid
Copy link
Copy Markdown
Member

@Felixoid Felixoid commented Dec 10, 2025 •
edited
Loading

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixes race condition for pull-prune conflicts. Fixes #80470

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 10, 2025 •
edited by Felixoid
Loading

Workflow [PR], commit [da91115]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_asan, db disk, old analyzer, 3/6) failure
test_storage_iceberg_with_spark/test_cluster_table_function.py::test_cluster_table_function_split_by_row_groups[1-0-s3-1] FAIL cidb

@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Dec 10, 2025

cc @qoega as original author
fixes #80470

@clickhouse-gh clickhouse-gh bot added the pr-ci label Dec 10, 2025
@Felixoid Felixoid mentioned this pull request Dec 10, 2025
Closed
@Algunenano Algunenano self-assigned this Dec 10, 2025
Algunenano
Algunenano approved these changes Dec 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding! I agree this was a bad idea

@qoega
Copy link
Copy Markdown
Member

qoega commented Dec 10, 2025

That was not a bad idea when we hit disk size. Maybe now we use different hardware and it is fine, but for local runs it may be impactful

@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Dec 11, 2025 •
edited
Loading

I am not arguing whether the idea was good or bad. How did it help with disks at the time it was added, though?

My understanding is that docker image prune -f removes untagged images. So, how did it improve the picture?

Unless we used latest, which hasn't been the case for quite a long time. Now, each downloaded image has its own digest, so this step should not help clean the disk.

@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Dec 11, 2025

test_storage_iceberg_with_spark/test_cluster_table_function.py::test_cluster_table_function_split_by_row_groups

@Felixoid Felixoid added this pull request to the merge queue Dec 11, 2025
Merged via the queue into master with commit 6fe4a0a Dec 11, 2025
498 of 508 checks passed
@Felixoid Felixoid deleted the dont-prune-images branch December 11, 2025 13:52
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: test_cgroup_limit/test.py::test_cgroup_cpu_limit

4 participants

@Felixoid @qoega @Algunenano @robot-ch-test-poll4