CI: Fix integration test detection for bugfix/flaky job flavors#91194
CI: Fix integration test detection for bugfix/flaky job flavors#91194
Conversation
|
Workflow [PR], commit [a64b58a] Summary: ❌
|
| if ( | ||
| file.startswith("tests/integration/test") | ||
| and Path(file).name.startswith("test_") | ||
| and Path(file).name.startswith("test") |
There was a problem hiding this comment.
Hm, so we will not run test on config changes? We should
Also initial problem was with stateless tests, how it will help?
There was a problem hiding this comment.
it should be implemented then (not in scope of this change), now there is no logic to derive changed tests from changed configs
ci/jobs/integration_test_job.py
Outdated
| ) | ||
|
|
||
| if is_bugfix_validation or is_flaky_check: | ||
| assert changed_test_modules, "No changed test modules found, either job must be skipped or bug in changed test search logic" |
There was a problem hiding this comment.
And this will fail the job completely instead of skipping it, should it do something like
Result.create_from(
status=Result.Status.SKIPPED,
info="...",
).complete_job()
There was a problem hiding this comment.
Then we won't notice a bug in the changed test detection logic, like the one fixed in this PR.
There was a problem hiding this comment.
If no tests were changed, the job is supposed to be skipped in the CI hook filter_job.py
Changelog category (leave one):
follow up #90360