Skip to content

Fix: do not attempt to convert constants in LIMIT/OFFSET expression to scalar.#90156

Merged
yakov-olkhovskiy merged 1 commit intomasterfrom
fix-constant-scalar-in-limit
Nov 19, 2025
Merged

Fix: do not attempt to convert constants in LIMIT/OFFSET expression to scalar.#90156
yakov-olkhovskiy merged 1 commit intomasterfrom
fix-constant-scalar-in-limit

Conversation

@yakov-olkhovskiy
Copy link
Copy Markdown
Member

@yakov-olkhovskiy yakov-olkhovskiy commented Nov 17, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Do not apply constant node optimization to LIMIT/OFFSET expression. Fixes #89607.

Details

Fixes #89607

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 17, 2025

Workflow [PR], commit [79291d9]

Summary:

job_name test_name status info comment
AST fuzzer (amd_ubsan) failure
Logical error: 'Expression nodes list expected 1 projection names. Actual: 0'. FAIL cidb
BuzzHouse (amd_debug) failure
Buzzing result failure cidb

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Nov 17, 2025
@novikd novikd self-assigned this Nov 17, 2025
@yakov-olkhovskiy yakov-olkhovskiy added this pull request to the merge queue Nov 19, 2025
Merged via the queue into master with commit efaa46e Nov 19, 2025
129 of 132 checks passed
@yakov-olkhovskiy yakov-olkhovskiy deleted the fix-constant-scalar-in-limit branch November 19, 2025 15:53
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical error: 'Bad cast from type DB::FunctionNode to DB::ConstantNode' with optimize_const_name_size

4 participants