Conversation
Contributor
|
Workflow [PR], commit [741f47b] Summary: ⏳
|
1 task
azat
reviewed
Oct 15, 2025
| /// We have this tryMulti for a very weird edge case when it's related to localhost. | ||
| /// Each replica may have a localhost as hostid and if we configured multiple replicas to add their | ||
| /// localhosts to some clusters multiple of them may think that they must mark it as active. | ||
| if (code != Coordination::Error::ZOK) |
Member
There was a problem hiding this comment.
Should we allow only Coordination::Error::ZNODEEXISTS error here?
Member
Author
There was a problem hiding this comment.
I'm afraid to break old behavior where it was just try/catch. So let's leave it as is.
azat
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #88342
This change breaks test logic, adds complexity and hides real bug.