Skip to content

Revert "Use system.completions table for suggestions"#87868

Merged
nikitamikhaylov merged 1 commit intomasterfrom
revert-84694-master
Sep 30, 2025
Merged

Revert "Use system.completions table for suggestions"#87868
nikitamikhaylov merged 1 commit intomasterfrom
revert-84694-master

Conversation

@nikitamikhaylov
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov commented Sep 29, 2025 •
edited
Loading

Reverts #84694

Test test_suggestions/test.py::test_suggestions_backwards_compatibility_for_multiple_suggestions_prefix is flaky.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 29, 2025 •
edited
Loading

Workflow [PR], commit [cc17700]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
02931_client_fuzzy_search_crash FAIL
Exception in test runner FAIL
Scraping part_log.1 FAIL
Scraping part_log.2 FAIL
Stress test (amd_ubsan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 29, 2025
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Sep 30, 2025
Merged via the queue into master with commit b189a4d Sep 30, 2025
120 of 123 checks passed
@nikitamikhaylov nikitamikhaylov deleted the revert-84694-master branch September 30, 2025 07:00
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 30, 2025
@azat azat mentioned this pull request Sep 30, 2025
Merged
1 task
@yakov-olkhovskiy yakov-olkhovskiy mentioned this pull request Sep 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikitamikhaylov @robot-ch-test-poll4