Fix incorrect coordination mode for empty ranges in parallel replicas local planning.#87700
Merged
devcrafter merged 1 commit intoClickHouse:masterfrom Sep 26, 2025
Merged
Conversation
Contributor
Author
|
cc @devcrafter |
devcrafter
reviewed
Sep 26, 2025
| number_of_current_replica.value_or(client_info.number_of_current_replica), | ||
| context->getClusterForParallelReplicas()->getShardsInfo().at(0).getAllNodeCount()}; | ||
|
|
||
| extension.sendInitialRequest(CoordinationMode::Default, result.parts_with_ranges, /*mark_segment_size=*/1); |
Member
There was a problem hiding this comment.
CoordinationMode::Default 🤦
Contributor
|
Workflow [PR], commit [ea0f10e] Summary: ❌
|
Merged
via the queue into
ClickHouse:master
with commit Sep 26, 2025
9f15c7c
239 of 242 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Parallel replicas read mode could be chosen incorrectly if there are no data to read after applying index analysis. Closes #87653