Query Condition Cache: Reduce lock contention#87337
Closed
zhongyuankai wants to merge 3 commits intoClickHouse:masterfrom
Closed
Query Condition Cache: Reduce lock contention#87337zhongyuankai wants to merge 3 commits intoClickHouse:masterfrom
zhongyuankai wants to merge 3 commits intoClickHouse:masterfrom
Conversation
Contributor
Author
|
@rschu1ze Please help review if you have time. |
Member
Didn't happen yet, sorry. |
Contributor
Contributor
|
Dear @rschu1ze, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #86076
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
For entries with the same key already present in the cache, clone the entry and cache it into the
QueryConditionCacheWriterto avoid unnecessary updates and reduce lock contention.Documentation entry for user-facing changes